Fix #1088 - Add support for custom credentials provider in runtime #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… runtime Signed-off-by: Ricardo Zanini <[email protected]>
ricardozanini
added
area:client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java
Dismissed
Show dismissed
Hide dismissed
...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java
Dismissed
Show dismissed
Hide dismissed
...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java
Dismissed
Show dismissed
Hide dismissed
...nt/runtime/src/main/java/io/quarkiverse/openapi/generator/providers/CredentialsProvider.java
Dismissed
Show dismissed
Hide dismissed
fjtirado
approved these changes
Apr 11, 2025
Member
Author
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
…1104) Signed-off-by: Ricardo Zanini <[email protected]>
7 tasks
hbelmiro
pushed a commit
that referenced
this pull request
Apr 12, 2025
…1104) (#1105) Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Contributor
There was a problem hiding this comment.
@ricardozanini The ConfigCredentialsProvider is never used for the oauth2 provider, right? both its own filter method and the one of the delegate are getting the value from the header, I think a method getOauth2Bearer should be introduced in the CredentialsProvider interface. We could re-use the getBearerToken but I find it more straightforward to have a dedicated method per provider.
This was referenced Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Fix #1088.
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.